Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Resampling #228

Merged
merged 23 commits into from
Jun 8, 2024
Merged

Virtual Resampling #228

merged 23 commits into from
Jun 8, 2024

Conversation

DanielJDufour
Copy link
Member

Type of PR

  • Bug Fix
  • Feature

What is the Goal of the PR?

What is the Motivation for the PR?

What Tests are Included?

@twelch twelch mentioned this pull request May 7, 2024
Closed
@DanielJDufour
Copy link
Member Author

I'm thinking of renaming the "vrm" (virtual resampling multiplier) param to "resample" for the stats function. "resample" is certainly more intuitive then "vrm" (which is something I just made up)

@DanielJDufour
fixed lint issue
70c3297
@DanielJDufour
increased served requests in intersect-polygon.test.js
bcfa92f
@DanielJDufour
updated flug and added 1 sec gap time between tests
f601b6b
@DanielJDufour
updated flug
9f2d7f1
@DanielJDufour
added virtual resampling test files
4017f1f
@DanielJDufour
serve more files in median test
56c9e16
@DanielJDufour
updated stats to return valid by default
8b5035f
@DanielJDufour
removed old code climate links
49371f0
@DanielJDufour
updated flug
dfb76b6
@DanielJDufour
added scaled valid values to stats test
25f5fdb
@DanielJDufour
removed frequency from stats tests
c8475fb
@DanielJDufour
added frequency to test expectation
846cb74
@DanielJDufour
removed debug logging
2101fa4
@DanielJDufour
try to fix ci testing issues
63b1e90
@DanielJDufour
changed debug level
f53c595
@DanielJDufour
trying to fix weird ci issue with fetching file by using readFileSync…
4faff44 
… instead
@DanielJDufour
added frequency to expected test result
ae55519
@DanielJDufour
add support for simple bbox obj resampling
bf45190
@DanielJDufour
fix linting issue by removing unused import in src/sum/index.js
9645c69
@DanielJDufour DanielJDufour changed the title WORK IN PROGRESS Virtual Resampling Jun 8, 2024
@DanielJDufour DanielJDufour marked this pull request as ready for review June 8, 2024 16:33
@DanielJDufour
Copy link
Member Author

Added minimal virtual resampling for stats functions, including default rescaling of sum results. Next steps are:

  • create documentation (virtual resampling should be experimental and subject to change if necessary)
  • cut a new release (with a changelog)
  • update geotiff.io, get build working again, create blog post demonstrating it

@DanielJDufour DanielJDufour merged commit 032d074 into master Jun 8, 2024
2 checks passed
@DanielJDufour DanielJDufour deleted the issue-56-virtual-resampling branch June 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanielJDufour