fixed issue 224 #225
Merged
fixed issue 224 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelch
approved these changes
Nov 26, 2023
| bbox: [xmin.toString(), ymin.toString(), xmax.toString(), ymax.toString()], | ||
| debug: false, | ||
| origin: [georaster.xmin.toString(), georaster.ymax.toString()], | ||
| overflow: false, | ||
| padding: ["1", "1"], // add a little padding in case the geometry is smaller than half a pixel |
There was a problem hiding this comment.
Will this always apply 1 pixel padding then? It makes sense
There was a problem hiding this comment.
yup, it'll add 1 pixel padding all around, so technically 2 new pixels along the horizontal axis and 2 along the vertical axis. if the geometry is really small and the original width is 0 pixels, the new width will be 2 pixels.
it won't solve the issue of trying to grab values when a geometry is a lot smaller than a pixel size, but my thinking is that it'll be one piece in that solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
What is the Goal of the PR?
fix issue #224
What is the Motivation for the PR?
What Tests are Included?
Test called "issue #224" in stats.test.js