improved antimeridian support #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be noted that geojson.io (and presumably LeafletJS) does handle the visualization of this geometry correctly. |
DanielJDufour
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall goal: improve anti-meridian support
Specifically I created this PR to share a new failing test. Basically, most GIS software including gdal, reproject-geojson and geoblaze do a poor of reprojecting geojson from 4326 if it overlaps the left edge of the world.
The example of when this geometry could be generated is likely when you draw an area in the Pacific that extends across the antimeridian and is found on the left side of the map view.
This is almost certainly an issue when reprojecting from other projections as well, but I haven't created a test case for that yet.