-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #11703] Documents can now be uploaded without specifying title via the REST API. #11872
base: master
Are you sure you want to change the base?
[Fixes #11703] Documents can now be uploaded without specifying title via the REST API. #11872
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11872 +/- ##
=======================================
Coverage 64.22% 64.23%
=======================================
Files 888 888
Lines 53551 53562 +11
Branches 6605 6605
=======================================
+ Hits 34392 34403 +11
Misses 17650 17650
Partials 1509 1509 |
@ahmdthr please take a look at the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently your test is failing
Sorry for the late response, but I was sick last week. I am going to fix the issues today. Thank you for waiting. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
59204 | Triggered | Django Secret Key | 6847825 | .devcontainer/.env | View secret |
59204 | Triggered | Django Secret Key | 6847825 | .env_local | View secret |
59204 | Triggered | Django Secret Key | 6847825 | .env_dev | View secret |
9705160 | Triggered | Username Password | 6847825 | geonode/base/api/tests.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
test are failing again @ahmdthr |
@giohappy The tests are fine now. The tests were failing after the introduction of "Assets". It can also be back-ported to 4.3, if needed. |
@ahmdthr what do you think of setting the file name instead of None in case the title is missing? |
Fixes#11703 Upload document via REST API v2 does not work
The document upload does not work without specifying the title. With this PR the document will be uploaded while setting the title as the name of the uploaded file.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.