bump version requirement to track upstream covr updates

Genentech · Jan 4, 2024 · 8ea20cb · 8ea20cb
1 parent 474446b
commit 8ea20cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/R/srcref_df.R b/R/srcref_df.R
@@ -90,16 +90,16 @@ pkg_srcrefs_df <- function(x) {
   srcs <- pkg_srcrefs(x)
   df <- as.data.frame(srcs)
   has_srcref <- vapply(df$srcref, inherits, logical(1L), "srcref")
-  df$namespace[] <- NA_character_
+  df[, "namespace"] <- NA_character_
 
-  df$namespace[has_srcref] <- vapply(
+  df[has_srcref, "namespace"] <- vapply(
     srcs[has_srcref],
     attr,
     character(1L),
     "namespace"
   )
 
-  df$namespace[!has_srcref] <- vapply(
+  df[!has_srcref, "namespace"] <- vapply(
     df$name[!has_srcref],
     obj_namespace_name,
     character(1L),

diff --git a/R/utils.R b/R/utils.R
@@ -15,7 +15,7 @@
 get_namespace_object_names <- function(ns) {
   out <- getNamespaceExports(ns)
   # filter private S4 methods tables and class definitions
-  out[!grepl("^\\.__(T|C)__", out)]
+  out[!grepl("^\\.__[TC]__", out)]
 }
 
 
@@ -24,7 +24,7 @@ get_namespace_object_names <- function(ns) {
 #'
 #' @importFrom utils packageVersion
 new_empty_test_trace_tally <- function() {
-  if (utils::packageVersion("covr") < "3.6.3") {
+  if (utils::packageVersion("covr") < "3.6.4.9000") {
     matrix(
       integer(0L),
       ncol = 4L,