Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create header #20

Merged
merged 10 commits into from
May 17, 2022
Merged

Create header #20

merged 10 commits into from
May 17, 2022

Conversation

Lembani
Copy link
Collaborator

@Lembani Lembani commented May 17, 2022

This PR contains the implementation of the header for the movie website project.

Highlights:

  • Add HTML markup for header
  • Add CSS styles for header
  • Build output in dist folder
  • etc

Copy link
Owner

@GedeonTS GedeonTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💯 ✅ 🥳 🎈 🎉

Hi @Lembani , 👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

(Highlights) Good points

No linters errors.
The pull request is following the Github workflow.
Good use of EC6 syntax.

Cheers and Happy coding!👏👏👏

@Lembani
Copy link
Collaborator Author

Lembani commented May 17, 2022

Thanks for approving my PR. 🙏🏾

@Lembani Lembani merged commit ec33894 into dev May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants