Issue 135 #165
Closed
Issue 135 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add steps for npx and npm environment integration
jrbuhl93
reviewed
Aug 20, 2021
| type `react-native run-ios` or `react-native run-android` to run locally. Follow the instruction [getting started](https://reactnative.dev/docs/getting-started) to have the correct setup. | ||
| cd into project folder | ||
|
|
||
| type `npm install` |
There was a problem hiding this comment.
We use yarn internally for the project, so I think we should recommend yarn install instead. Or have both: yarn install or npm install .
|
|
||
| type `npm install` | ||
|
|
||
| `npx react-native start` to start metro. |
There was a problem hiding this comment.
react-native start or npx react-native start to be consistent with other lines.
jrbuhl93
reviewed
Aug 20, 2021
| @@ -131,7 +131,7 @@ export const MapScreen: ScreenType = ({ navigation }: Props) => { | |||
| ? navigation.navigate("sendBitcoin", { username: item.username }) | |||
| : navigation.navigate("phoneValidation") | |||
| markers.push( | |||
| <Marker coordinate={item.coordinate} key={item.title}> | |||
| <Marker coordinate={item.coordinate} key={item.title} pinColor={'#FF8000'}> | |||
There was a problem hiding this comment.
We may also want to extract this into https://github.com/GaloyMoney/galoy-mobile/blob/main/app/theme/palette.ts . Or use the orange from that file.
MikeMwambia-TrojanSystem
pushed a commit
to MikeMwambia-TrojanSystem/galoy-mobile
that referenced
this pull request
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change pin color