Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate compilation warnings #677

Merged
merged 10 commits into from
Apr 22, 2020
Merged

Eliminate compilation warnings #677

merged 10 commits into from
Apr 22, 2020

Conversation

chameco
Copy link
Contributor

@chameco chameco commented Apr 14, 2020

It might also be nice to reintroduce -Werror in saw-script.cabal, although I'm not sure if that would negatively impact others' development workflows.

@brianhuffman
Copy link
Contributor

Instead of putting -Werror in the cabal file (which can cause headaches for developers, as you say) maybe we should be doing our CI builds with -Werror on the command line. This way we can allow warnings in local builds by default, but we can disallow merges to master that introduce warnings.

@chameco
Copy link
Contributor Author

chameco commented Apr 17, 2020

This is unfortunately complicated a bit by haskell/cabal#3883. Other projects backlinking to that issue (e.g. github/semantic#428) appear to circumvent the issue by adding a CI-specific cabal.project that adds -Werror to ghc-options.

Considering this, I suspect that appending

package saw-script
  ghc-options: -Werror

to cabal.project during Travis setup is a reasonable (but ugly ☹️) solution.

@chameco chameco merged commit ac2f227 into master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants