Split on unique conditions. #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Jan 15, 2024
| @@ -936,7 +936,7 @@ hoistIfs sc t = do | |||
| let ss :: Simpset () = addRules rules emptySimpset | |||
|
|
|||
| (t', conds) <- doHoistIfs sc ss cache itePat . snd =<< rewriteSharedTerm sc ss t | |||
| splitConds sc ss (map fst conds) t' | |||
| splitConds sc ss (Set.toList $ Set.fromList $ map fst conds) t' | |||
There was a problem hiding this comment.
I'd recommend using nubOrd from Data.List.Extra, which we already use in other parts of saw-script:
import Data.List.Extra (nubOrd)
...
splitConds sc ss (nubOrd $ map fst conds) t'| @@ -936,7 +936,7 @@ hoistIfs sc t = do | |||
| let ss :: Simpset () = addRules rules emptySimpset | |||
|
|
|||
| (t', conds) <- doHoistIfs sc ss cache itePat . snd =<< rewriteSharedTerm sc ss t | |||
| splitConds sc ss (map fst conds) t' | |||
| splitConds sc ss (Set.toList $ Set.fromList $ map fst conds) t' | |||
There was a problem hiding this comment.
This deserves some comments about why we need to remove duplicates here.
kquick
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.