Support building with GHC 9.4 #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly, the I certainly didn't intend for any user-visible behavior to change with this patch, but perhaps this is a consequence of bumping one of the submodules, such as |
|
I've identified GaloisInc/what4#232 as the change which introduced the |
Merged
This contains a variety of tweaks needed to build SAW with GHC 9.4: * GHC 9.4 is more conservative about inferring superclass constraints that arise from functional dependencies (see [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#constraints-derived-from-superclasses) of the GHC 9.4 Migration Guide), so we must add explicit `m ~ Identity` constraints to certain parts of `heapster-saw` to make it compile with GHC 9.4. * I raised the upper version bounds on `aeson` and `vector` to allow building them with GHC 9.4. * The following submodule changes were brought in to support building with GHC 9.4: * `argo`: #193 * `crucible`: GaloisInc/crucible#1073 (This also requires bumping the `llvm-pretty`, `llvm-pretty-bc-parser`, and `what4` submodules as a side effect) * `language-sally`: GaloisInc/language-sally#13 * `macaw`: GaloisInc/macaw#330 * `parameterized-utils`: GaloisInc/parameterized-utils#146 Fixes #1852.
GHC 9.4 adds `-Wtype-equality-requires-operators` to `-Wall`, which warns about certain uses of type equalities that are not forward-compatible with planned changes in GHC. See [this section](https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.4?version_id=b60e52482a666d25638d59cd7e86851ddf971dc1#-is-now-a-type-operator) of the GHC 9.4 Migration Guide. These warnings are easily fixed by enabling the `TypeOperators` extension.
This produces a `-Wgadt-mono-local-binds` warning with GHC 9.4, which has added the warning to `-Wall`. To avoid the warning, I have removed a use of `NoMonoLocalBinds` in `SAWScript.Crucible.JVM.BuiltinsJVM`. This required adding an explicit type signature to `failure` as a result.
|
With @andreistefanescu's help, the CI passes with the changes from GaloisInc/what4#232. Let's land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a variety of tweaks needed to build SAW with GHC 9.4:
m ~ Identityconstraints to certain parts ofheapster-sawto make it compile with GHC 9.4.aesonandvectorto allow building them with GHC 9.4.argo: crucible_fresh_pointer doesn't work with non-memtypes #193crucible: Support building with GHC 9.4 crucible#1073(This also requires bumping the
llvm-pretty,llvm-pretty-bc-parser, andwhat4submodules as a side effect)language-sally: Allow building withbase-4.17(GHC 9.4) language-sally#13macaw: Support building with GHC 9.4 macaw#330parameterized-utils: Allow building with GHC 9.4 parameterized-utils#146Fixes #1852.