Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't define Rust-related .bc Makefile rules on CI #1802

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Don't define Rust-related .bc Makefile rules on CI #1802

merged 1 commit into from
Jan 18, 2023

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented Jan 17, 2023 •
edited
Loading

This avoids the potential for spurious rebuilding in certain situations where the .bc files have different created and modified timestamps.

Fixes #1801.

@eddywestbrook
Copy link
Contributor

Instead of doing a touch, why don't we just change the Heapster Makefile rules for generating .bc files from Rust to be conditional, so they don't get turned on in CI? There is already a similar provision for doing that for the .bc files generated from C, and the Rust rules could do the same thing.

@RyanGlScott
Copy link
Contributor Author

Good idea. I've pushed a new version that implements your suggestion.

@RyanGlScott RyanGlScott changed the title CI: Run touch on .bc files before make in heapster-tests Don't define Rust-related .bc Makefile rules on CI Jan 17, 2023
kquick
kquick approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requested some informational commenting, but otherwise this looks good, and time will validate whether this is indeed the fix.

heapster-saw/examples/Makefile Show resolved Hide resolved
@RyanGlScott
Don't define Rust-related .bc Makefile rules on CI
7842ec0 
This avoids the potential for spurious rebuilding in certain situations where
the `.bc` files have different created and modified timestamps.

Fixes #1801.
@RyanGlScott RyanGlScott added the ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully. label Jan 17, 2023
@mergify mergify bot merged commit c5c4051 into master Jan 18, 2023
@mergify mergify bot deleted the T1801 branch January 18, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kquick kquick kquick approved these changes

Assignees
No one assigned
Labels
ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nondeterministic CI failures due to Makefile recompliation checking in heapster-tests
3 participants
@RyanGlScott @eddywestbrook @kquick