Reduce memory use of x86 disassembly #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch brings in the changes from GaloisInc/flexdis86#43, which redesigns the x86_64 disassembler in `flexdis86` to use a substantially smaller lookup table, thereby saving a fair bit of resident memory when doing x86-related proofs.
Merged
|
I was hoping that this might save enough memory to get PRs like #1689 to run within the memory limits of GitHub Actions runners. Alas, this doesn't appear to be the case. This PR would still be worthwhile on its own merits, however. For instance, @robdockins reports that a large SAW proof he is working on went from using 16+ GB of RAM to using only ~12.5 GB after this patch. |
chameco
approved these changes
Jul 5, 2022
RyanGlScott
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings in the changes from GaloisInc/flexdis86#43, which redesigns the x86_64 disassembler in
flexdis86to use a substantially smaller lookup table, thereby saving a fair bit of resident memory when doing x86-related proofs.