Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule versions. #1455

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Update submodule versions. #1455

merged 2 commits into from
Sep 15, 2021

Conversation

brianhuffman
Copy link
Contributor

No description provided.

@brianhuffman
Copy link
Contributor Author

The ubuntu CI builds are failing with this message:

+ [[ Linux == \W\i\n\d\o\w\s ]]
+ IS_WIN=false
++ pwd
+ BIN=/home/runner/work/saw-script/saw-script/bin
+ EXT=
+ false
+ mkdir -p /home/runner/work/saw-script/saw-script/bin
+ COMMAND=build
+ shift
+ build
++ ghc --numeric-version
+ ghc_ver=9.0.1
+ cp cabal.GHC-9.0.1.config cabal.project.freeze
cp: cannot stat 'cabal.GHC-9.0.1.config': No such file or directory
Error: Process completed with exit code 1.

@RyanGlScott
Copy link
Contributor

This is quite bizarre. ghc_ver comes from here:

saw-script/.github/ci.sh

Lines 109 to 110 in 58ca144

ghc_ver="$(ghc --numeric-version)"
cp cabal.GHC-"$ghc_ver".config cabal.project.freeze

This would suggest that CI is downloading GHC 9.0.1 somehow. Yet the CI logs disagree with this claim:

Installing ghc version 8.10.3

I have no idea how GHC 9.0.1 is ending up on the PATH.

@RyanGlScott
Copy link
Contributor

I'm starting to suspect that this is a bug in haskell/actions, since I am experiencing the same problem on a completely different repo (logs).

@RyanGlScott
Copy link
Contributor

This might be due to haskell/actions#73.

@atomb
Copy link
Contributor

atomb commented Sep 15, 2021

Strange that it's only doing that under Ubuntu. The bug is affecting Cryptol, too. We could add a ghcup set ghc line to ci.sh to work around it (and it wouldn't cause any harm to leave in, though it would be crufty). We'd have to do that in essentially all our Haskell builds on GitHub, though. Maybe we can hope they fix it soon?

@atomb
Copy link
Contributor

atomb commented Sep 15, 2021

Oh, @jared-w is the main contributor. Maybe we should bug him. :)

@brianhuffman brianhuffman added the ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully. label Sep 15, 2021
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and CI results are promising so far.

@mergify mergify bot merged commit 55ca13b into master Sep 15, 2021
@mergify mergify bot deleted the update-deps branch September 15, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully. submodule bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants