Add new pretty-printer precedence level for comma-separated lists. #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
May 5, 2021
| @@ -114,28 +114,19 @@ depthAllowed _ _ = True | |||
|
|
|||
| -- | Precedence levels, each of which corresponds to a parsing nonterminal | |||
| data Prec | |||
| = PrecNone -- ^ Nonterminal 'Term' | |||
| = PrecNone -- ^ Nonterminal 'Term' or "sepBy(Term, ',')" | |||
There was a problem hiding this comment.
Minor Haddock nit: text enclosed in double quotes denote links to names of modules, which I don't think you intended. Use this to make it render using a plain monospace font:
Suggested change
| = PrecNone -- ^ Nonterminal 'Term' or "sepBy(Term, ',')" | |
| = PrecNone -- ^ Nonterminal 'Term' or @sepBy(Term, \',\')@ |
Escaping the single quotes is also necessary to prevent Haddock from trying to hyperlink , as an identifier name.
| @@ -114,28 +114,19 @@ depthAllowed _ _ = True | |||
|
|
|||
| -- | Precedence levels, each of which corresponds to a parsing nonterminal | |||
| data Prec | |||
| = PrecNone -- ^ Nonterminal 'Term' | |||
| = PrecNone -- ^ Nonterminal 'Term' or "sepBy(Term, ',')" | |||
| | PrecTerm -- ^ Nonterminal 'Term' | |||
There was a problem hiding this comment.
Both PrecTerm and PrecNone have the description "Nonterminal Term", but is there ever a situation where you'd use PrecNone for something besides a tuple?
There was a problem hiding this comment.
Now that I think about it, no, actually there's not. In that case it's probably a good idea to rename the constructor to something like PrecCommas, to reflect its actual purpose.
added 3 commits
May 5, 2021 08:06
This lets us print pair values using infix ',' with parens in the right places. Fixes #1147.
RyanGlScott
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us print pair values using infix ',' with parens in the right places.
Fixes #1147.