Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptol-saw-core: Fix tuple encoding used by proveEq. #1275

Merged
merged 1 commit into from
May 5, 2021
Merged

cryptol-saw-core: Fix tuple encoding used by proveEq. #1275

merged 1 commit into from
May 5, 2021

Conversation

brianhuffman
Copy link
Contributor

Fixes #1166.

robdockins
robdockins approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in recognizing the case where a1 == a2 and b1 ==b2? Then perhaps we could just emit a Refl...

@brianhuffman
Copy link
Contributor Author

The case where a1 == a2 and b1 == b2 should never happen, because there is already an outer level guard that checks whether t1 == t2 and produces a Refl in that case. So in this branch we already know that the two types differ somewhere.

@brianhuffman brianhuffman added the ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully. label May 4, 2021
@mergify mergify bot merged commit e9b20e6 into master May 5, 2021
@mergify mergify bot deleted the issue1166 branch May 5, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
ready-to-merge If at least one person approves this PR, automatically merge it when CI finishes successfully.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAW fails silently
2 participants
@brianhuffman @robdockins