Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Coq Ident type into a newtype #1253

Open
brianhuffman opened this issue Dec 2, 2020 · 0 comments
Open

Make Coq Ident type into a newtype #1253

brianhuffman opened this issue Dec 2, 2020 · 0 comments
Assignees
Labels
saw-core-coq Related to saw-core-coq package tech-debt

Comments

@brianhuffman
Copy link
Contributor

Making the Coq Ident type into a type that is distinct from String would help to avoid the kind of bugs that aba230b68bf06700e845d00f452e5c7230342483 is trying to fix, where in the translator code we simply forgot to translate some of the bound names. (See comments on GaloisInc/saw-core-coq#29.)

Another advantage of having an abstract type is that we could freely change its representation later (e.g. to Text). It would also make the code arguably easier to understand and to maintain.

@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core-coq Jan 21, 2021
@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core Apr 27, 2021
@brianhuffman brianhuffman added saw-core-coq Related to saw-core-coq package tech-debt labels Apr 27, 2021
brianhuffman pushed a commit that referenced this issue Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
saw-core-coq Related to saw-core-coq package tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants