aarch32-symbolic: Setting up an ABI-compatible stack #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,249 @@ | |||
| {-| | |||
There was a problem hiding this comment.
@RyanGlScott There's a lot of code here that's basically equivalent to the code for the x86_64 SysV ABI, particularly the part about writing spilled arguments to the stack while maintaining proper alignment. Do you have thoughts on the best way to share between the two (or if we should share it)? I could lift writeSpilledArgs to Data.Macaw.Symbolic.Stack perhaps, with a note that it's only appropriate for use on certain ABIs, and that you'd probably want to use the specializations of it that we would provide in Data.Macaw.{X86,AArch32}.Symbolic.ABI?
There was a problem hiding this comment.
I think putting the shared code (with caveats that it is only valid for certain ABIs) in macaw-symbolic is fine.
langston-barrett
force-pushed
the
lb/arm-abi
branch
from
cb7b4a4
to
14f3124
Compare
added 2 commits
September 20, 2024 17:29
...so that it can also be used by AArch32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #433 + #437, but for AArch32. Towards #430. Based on #438. Needs to be integrated into the test suite for validation.