crucible-wasm: Build and test with the latest haskell-wasm commit
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and values This bumps the `haskell-wasm` commit to SPY/haskell-wasm@51cf7e7 and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. For now, we do not implement full support for Wasm's reference types and values, as that would require a non-trivial amount of work to support. See #1228.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@de40134 and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. For now, we do not implement full support for Wasm 2.0's new element segment features, as that would require a non-trivial amount of work to support. See #1228.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@4753ebc. For now, we do not implement Wasm 2.0's new table-related instructions, as that would require a non-trivial amount of work to support. See #1228.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@82defff and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. In particular: * The `call_indirect` instruction has been generalized so that it can accept an arbitrary table index, rather than always hard-coding the table index to 0. This is straightforward to generalize on the `crucible-wasm` side as well. * Wasm 2.0 has a new `elem.drop` instruction. For now, we do not implement support for this instruction.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@c743e11 and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. In particular, the `select` instruction now has an optional value type indicating the type of its first and second operand, which `crucible-wasm` ignores. This is OK for now, as `crucible-wasm`'s implementation is currently simple enough where the types of all its stack values can be inferred without any additional type information.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@32392dc and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. For now, we do not implement full support for Wasm 2.0's new data segment features, as that would require a non-trivial amount of work to support. See #1228.
This bumps the `haskell-wasm` commit to SPY/haskell-wasm@2bf6e88 and does the minimum amount of work needed to make `crucible-wasm` continue to compile after these changes. In particular: * `CurrentMemory` and `GrowMemory` were renamed to `MemorySize` and `MemoryGrow`, so I've performed the corresponding renaming on the `crucible-wasm` side as well. * For now, I have not added support for the `memory.fill`, `memory.copy`, `memory.init`, or `data.drop` instructions, all of which are new in Wasm 2.0.
We have recently made some changes to the way `crucible-wasm` handled element segments, so this test case helps ensure that we have not broken anything that used to work before.
We have recently made some changes to the way `crucible-wasm` handled the `select` instruction, so this test case helps ensure that we have not broken anything that used to work before.
RyanGlScott
force-pushed
the
T1227-latest-haskell-wasm-commit
branch
from
5348b60
to
c066611
Compare
mccleeary-galois
approved these changes
Aug 1, 2024
| @@ -622,11 +622,11 @@ genInstruction genReturn im st ctrlStack instr = | |||
| Just (ConstantGlobal _) -> panic "genInstruction: SetGlobal" ["setGlobal of constant global"] | |||
| Just (MutableGlobal gv) -> writeGlobal gv =<< checkStackVal (globalType gv) =<< popStack | |||
|
|
|||
| Wasm.CurrentMemory -> | |||
| Wasm.MemorySize -> | |||
There was a problem hiding this comment.
Should we add the following to a ticket as well so it doesn't get lost?
I have not added support for the
memory.fill,memory.copy,
memory.init, ordata.dropinstructions, all of which are new in Wasm 2.0.
There was a problem hiding this comment.
I've opened #1233 for this.
kquick
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a series of small patches that makes
crucible-wasmcompile with the latesthaskell-wasmcommit (at the time of writing, this is SPY/haskell-wasm@23aef00). Moreover, in places wherecrucible-wasm's test suite was lacking, I have added some additional test cases to ensure that any changes introduced in this PR did not cause inadvertent regressions.Most of the changes on the
haskell-wasmside are to adapt to new features in Wasm 2.0. Generally speaking, I have not gone through the effort of implementing support for all of Wasm 2.0's new features, instead leaving that as future work. One particularly notable feature which I did not implement is support for reference types and values, which would require a non-trivial amount of work to support on thecrucible-wasmside. See #1228.After these changes, we will finally be building against a version of
haskell-wasmthat support GHC 9.8. This will allow us to then add support for GHC 9.8 elsewhere in thecruciblerepo.Fixes #1227.