develop -> main #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ga-yo
reviewed
Jun 21, 2021
| @@ -42,32 +41,32 @@ class HomeworkAssignedViewController: UIViewController { | |||
| } | |||
|
|
|||
| func getContent(id: Int) { | |||
There was a problem hiding this comment.
함수도 외부의 접근이 필요하지 않다면 private로 설정해주세요 :) 이외에도 다른 프로퍼티들도 마찬가지입니당!
Ga-yo
reviewed
Jun 21, 2021
| getOrdView() | ||
| getSubView() | ||
|
|
||
| self.assignedTableView.reloadData() |
Ga-yo
reviewed
Jun 21, 2021
| @@ -8,11 +8,8 @@ | |||
| import UIKit | |||
| import FSCalendar | |||
|
|
|||
| // MARK: Calendar2VC | |||
| class Calendar2VC: UIViewController { | |||
There was a problem hiding this comment.
이거 VC말고 ViewController로 하면 좋을 것 같아요 : )
There was a problem hiding this comment.
Calendar 뒤에 2는 왜 붙인거죠?? 필요없다면 지워주세요!!
Ga-yo
reviewed
Jun 21, 2021
| calendar.scrollDirection = .vertical | ||
|
|
||
| } | ||
|
|
||
| func setUpEvents() { | ||
| formatter.locale = Locale(identifier: "ko_KR") |
There was a problem hiding this comment.
setup은 하나로 묶어지기 때문에 setUp이 아닌 setup이 올바른 네이밍입니당
Ga-yo
reviewed
Jun 21, 2021
GRAMO/GRAMO/VC/Auth/SignUpVC.swift
Outdated
| @IBOutlet weak var pwTxtField: UITextField! | ||
| @IBOutlet weak var pwConformTxtField: UITextField! | ||
|
|
||
| @IBOutlet weak var authenticationBtn: UIButton! |
There was a problem hiding this comment.
서영이랑 네이밍 포맷이 안맞는 것 같은데 누구는 Button이라고 하고 누구는 Btn이라고 하면 코드가 깔끔해보이지 않을 것 같아용:) 협업할 때 네이밍 컨벤션을 어느정도 맞추는게 좋아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.