Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for opening local files in spreadsheet/SV inspector #2074

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 24, 2021

This fixes the ability to open local files in spreadsheet/sv inspector. This was a regression following the change of our FileSelector to return the objects with blobId instead of blob from #1975

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #2074 (2aa7f3a) into main (24dc8b4) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   61.38%   61.41%   +0.02%     
==========================================
  Files         479      479              
  Lines       22908    22908              
  Branches     5249     5249              
==========================================
+ Hits        14062    14068       +6     
+ Misses       8571     8565       -6     
  Partials      275      275              
Impacted Files Coverage Δ
...iew/src/SpreadsheetView/components/ImportWizard.js 78.94% <ø> (ø)
...et-view/src/SpreadsheetView/models/ImportWizard.ts 70.70% <50.00%> (ø)
packages/core/util/index.ts 78.30% <0.00%> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dc8b4...2aa7f3a. Read the comment docs.

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 24, 2021
@cmdcolin
Copy link
Collaborator Author

I think implementing sv inspector/spreadsheet in typescript could maybe help avoid some regressions like this. Maybe we can merge this for now though

@cmdcolin cmdcolin merged commit d18857c into main Jun 24, 2021
@cmdcolin cmdcolin deleted the support_local_file_spreadsheet branch June 24, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant