Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Demo Exchange" to LightningBitcoinExtension #759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnzweng
Copy link
Contributor

@johnzweng johnzweng commented Sep 12, 2022

Description:

To be able to test also with dummy exchange, I added Dummy Exchange support for currency LBTC

Sidenote: was created to test this issue here: https://generalbytes.atlassian.net/browse/BPUB-1895

@pvyhnal-generalbytes
Copy link
Contributor

note we'll have to fix BPUB-1895 before merging this

@johnzweng
Copy link
Contributor Author

note we'll have to fix BPUB-1895 before merging this

@pvyhnal-generalbytes technically: Not necessarily. 🙂 By just merging this, nothing will change. BPUB-1895 describes an error which happens with any LBTC exchange. As soon as any exchange for LBTC is configured, the problem will occur.

This PR here just adds a Demo Exchange, which does nothing and shouldn't be used in production. But of course I understand your caution. As soon as there is a LBTC exchange available in the dropdown menu (and even if it is this Demo Exchange), people might configure it and run into the BPUB-1895 problem (which was reported by me).

So I'm totally fine if you wait for BPUB-1895 before merging this (I just added it to a custom extension for my tests). 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants