Added Support for UCA coin and BKEX exchange #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalbytes
requested changes
Nov 8, 2020
| } | ||
|
|
||
| // all CRYPTO_FIAT combinations are supported | ||
| private static final ImmutableSet<String> FIAT_CURRENCIES = ImmutableSet.of(CryptoCurrency.USDT.getCode()); |
There was a problem hiding this comment.
USDT cannot be fiat currency. Use USD in this set and later when calling exchange remap it to USDT.
| // TODO: handle exception | ||
| } | ||
|
|
||
| /* |
|
|
||
| @Override | ||
| public String sendCoins(String destinationAddress, BigDecimal amount, String cryptoCurrency, String description) { | ||
| return null; |
There was a problem hiding this comment.
Are you sure that exchange doesn't support withdrawals?
| @@ -501,7 +501,7 @@ private void getExchangeBalance(String name, String params) { | |||
| System.err.println("Exchange returned NULL."); | |||
| } | |||
| final String depositAddress = e.getDepositAddress(selectedCryptoCurrency); | |||
| System.out.println("Deposit Address: " + depositAddress); | |||
| System.out.println("Deposit Address: " + depositAddress); | |||
| <param name="walletAddress" /> | ||
| <cryptocurrency>UCA</cryptocurrency> | ||
| </wallet> | ||
| <ratesource prefix="digifinexRateSource" name ="Digifinex Rate Source" > |
There was a problem hiding this comment.
digifinexRateSource implementation is missing
| StringTokenizer st = new StringTokenizer(sourceLogin,":"); | ||
| String exchangeType = st.nextToken(); | ||
|
|
||
| if ("bkexRateSource".equalsIgnoreCase(exchangeType)) { |
There was a problem hiding this comment.
make "bkexRateSource" lowercase = "bkexratesource"
don't forget to fix also xml.
| <param name="fiatCurrency" /> | ||
| <cryptocurrency>UCA</cryptocurrency> | ||
| </ratesource> | ||
| <exchange prefix="digifinex" name="DigiFinex"> |
There was a problem hiding this comment.
digifinex implementation is missing.
| <param name="fiatCurrency" /> | ||
| <cryptocurrency>UCA</cryptocurrency> | ||
| </ratesource> | ||
| <ratesource prefix="bkexRateSource" name ="Bkex Rate Source" > |
| <param name="fiatcurrency"/> | ||
| <cryptocurrency>UCA</cryptocurrency> | ||
| </exchange> | ||
| <cryptologo cryptocurrency="UCA" file="xpm.png"/> |
There was a problem hiding this comment.
xpm.png and svg is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.