Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Unscripted Stage Log Trace (missing toString for Stage) #2603

Merged
merged 2 commits into from
May 29, 2024
Merged

[BUGFIX] Unscripted Stage Log Trace (missing toString for Stage) #2603

merged 2 commits into from
May 29, 2024

Conversation

gamerbross
Copy link
Contributor

Before:

source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: (x: 0 | y: 0 | w: 0 | h: 0 | visible: true | velocity: (x: 0 | y: 0))
source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: (x: 0 | y: 0 | w: 0 | h: 0 | visible: true | velocity: (x: 0 | y: 0))
source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: (x: 0 | y: 0 | w: 0 | h: 0 | visible: true | velocity: (x: 0 | y: 0))

After:

source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: mainStage
source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: mallEvil
source/funkin/data/BaseRegistry.hx:120:   Loaded entry data: mallXmas

@gamerbross gamerbross changed the title [BUGFIX] Fix Unscripted Stage Log Trace [BUGFIX] Unscripted Stage Log Trace May 24, 2024
@ninjamuffin99 ninjamuffin99 added this to the 0.4.0 milestone May 28, 2024
@ninjamuffin99
Copy link
Member

I will ping @EliteMasterEric on this one, to see what the intended behaviour for this debug log for BaseRegistry is !

@gamerbross
Copy link
Contributor Author

I shouldn't have modified BaseRegistry, the issue was with Stage class, which didn't have toString function, i just changed it

@gamerbross gamerbross changed the title [BUGFIX] Unscripted Stage Log Trace [BUGFIX] Unscripted Stage Log Trace (missing toString for Stage) May 28, 2024
EliteMasterEric
EliteMasterEric approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@EliteMasterEric EliteMasterEric merged commit eeaae74 into FunkinCrew:develop May 29, 2024
@gamerbross gamerbross deleted the bugfix/unscripted-stage-trace branch May 29, 2024 12:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gamerbross @ninjamuffin99 @EliteMasterEric