Update to paddings on wrap utility class #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lroliphant
commented
Jan 29, 2016
lroliphant
commented
- keep default padding of 16px on mobile devices
- increase padding to 24px on screen widths larger than 640px
- small fix - 1st step towards wider design/dev review of column padding across site
- bump patch version
* keep default padding of 16px on mobile devices * increase padding to 24px on screen widths larger than 640px * small fix - 1st step towards wider design/dev review of column padding across site * bump patch version
|
@thejuanitalee for review from US side please 👀 |
|
LGTM. One question, do we push the dist changes as well? It's been awhile for me. Sent from my Rotary Phone
|
|
@lroliphant can we merge this? |
|
@igoratron just waiting for Adam to confirm he is happy and then yes |
* update to mobile first approach in wrap class * upgrade gulp-sass version to version compatible with newer node versions
lroliphant
force-pushed
the
lo-wrap-class-amend
branch
from
975f6b1
to
e8deb74
Compare
|
LGTM 🐑 🇮🇹 |
lroliphant
pushed a commit
that referenced
this pull request
Mar 4, 2016
Update to paddings on wrap utility class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.