new sliding window by time function #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dont forget to add tests :D https://github.com/FundingCircle/jackdaw/blob/master/test/jackdaw/streams_test.clj |
|
@kidpollo I have (finally) added the test. Also looked at my implementation and made some modifications. Let me know what you think |
kidpollo
approved these changes
Jul 8, 2024
|
It doesn't pass the tests. We are getting intermediate values from the windows. Will try suppressing those until the windows close |
|
@kidpollo This is done, tests are now passing. |
@kidpollo Great, thanks! Hope it will get merged too! |
|
Any updates here? @kidpollo |
|
Unfortunately I am no longer an FC employee and have no insight on who actually runs this project :P maybe @jbropho ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented sliding window functionality