Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialized without topic name #263

Closed

Conversation

dacreify
Copy link

Summary

Fix for #262 by using alternate means of constructing a Materialized

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@dacreify dacreify requested a review from a team as a code owner June 29, 2020 18:24
@dacreify dacreify changed the title fix for #262 Materialized without topic name Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #263 into master will decrease coverage by 0.36%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   81.26%   80.89%   -0.37%     
==========================================
  Files          41       41              
  Lines        2562     2565       +3     
  Branches      149      149              
==========================================
- Hits         2082     2075       -7     
- Misses        331      341      +10     
  Partials      149      149              
Impacted Files Coverage Δ
src/jackdaw/streams/interop.clj 81.33% <83.33%> (+0.77%) ⬆️
src/jackdaw/serdes/edn2.clj 45.45% <0.00%> (-45.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f654f...406bcba. Read the comment docs.

@cddr
Copy link
Contributor

cddr commented Jun 30, 2020

LGTM

@dacreify
Copy link
Author

Superseded by: #335

@dacreify dacreify closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants