Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal 0.12.1 #52

Merged
merged 655 commits into from
Mar 12, 2024
Merged

Update internal 0.12.1 #52

merged 655 commits into from
Mar 12, 2024

Conversation

maiarareinaldo
Copy link
Collaborator

@maiarareinaldo maiarareinaldo commented Feb 20, 2024

Description

Update fork with version 0.12.1. Also added the feature to Glue recipes to pass in the catalog_alias which is used in the dataset URNs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

alexklavensnyt and others added 30 commits October 30, 2023 14:13
Co-authored-by: Hyejin Yoon <0327jane@gmail.com>
…tahub-project#8911)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Co-authored-by: John Joyce <john@acryl.io>
)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
datahub-project#9123)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
token: ${{ secrets.CODECOV_TOKEN }}
directory: .
fail_ci_if_error: false
flags: airflow-${{ matrix.python-version }}-${{ matrix.extraPythonRequirement }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
property "extrapythonrequirement" is not defined in object type {extra_pip_extras: string; extra_pip_requirements: string; python-version: number} [expression]

platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:120: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base-Slim) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:130: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute DataHub Ingestion (Base-Full) Tag
id: tag
run: echo "tag=${{ steps.filter.outputs.datahub-ingestion-base == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:125: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute Tag
id: tag
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:184: Double quote to prevent globbing and word splitting [shellcheck]

platforms: linux/amd64,linux/arm64/v8
- name: Compute Tag (Full)
id: tag
run: echo "tag=${{ (steps.filter.outputs.datahub-ingestion-base == 'true' || steps.filter.outputs.datahub-ingestion == 'true') && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:174: Double quote to prevent globbing and word splitting [shellcheck]

@maiarareinaldo maiarareinaldo force-pushed the update-internal-0.12.1 branch 2 times, most recently from 83b6238 to 8d58984 Compare March 1, 2024 11:19
@maiarareinaldo maiarareinaldo force-pushed the update-internal-0.12.1 branch 2 times, most recently from f468462 to d71fcd3 Compare March 4, 2024 13:14
@maiarareinaldo maiarareinaldo marked this pull request as ready for review March 4, 2024 16:37
@maiarareinaldo maiarareinaldo force-pushed the update-internal-0.12.1 branch 4 times, most recently from d78a502 to 8f2a7d4 Compare March 7, 2024 14:50
@maiarareinaldo maiarareinaldo merged commit 1107629 into internal Mar 12, 2024
86 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet