Skip to content

Commit

Permalink
Fix docker deploy steps conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
maiarareinaldo committed Feb 9, 2024
1 parent f386b3f commit c49beb0
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ anchors:
- ARTIFACTORY_USER
- GITHUB_TOKEN

when_internal_branch: &when_internal_branch
when:
event: [push]
branch: [internal]

steps:
- name: setup
image: ubuntu
Expand All @@ -59,8 +64,20 @@ steps:
ENVIRONMENT: production
AMPLITUDE_API_KEY: f0b9cf5c530426c3dbacb91e74f009a5

Check failure on line 65 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Raw output
Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials

Check failure on line 65 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).
Raw output
Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials

# Push the staging image, tagged with the branch name. Useful for testing the image in fc-datahub.
- name: docker_frontend_development
<<: *docker_build_config
settings:
context : /drone/src/staging/
dockerfile: /drone/src/staging/docker/datahub-frontend/Dockerfile
tags:
- ${DRONE_BRANCH//\//-}
depends_on:
- build_frontend_staging

- name: docker_frontend_staging
<<: *docker_build_config
<<: *when_internal_branch
settings:
context: /drone/src/staging/
dockerfile: /drone/src/staging/docker/datahub-frontend/Dockerfile
Expand All @@ -71,6 +88,7 @@ steps:

- name: docker_frontend_production
<<: *docker_build_config
<<: *when_internal_branch
settings:
context: /drone/src/production/
dockerfile: /drone/src/production/docker/datahub-frontend/Dockerfile
Expand Down

0 comments on commit c49beb0

Please sign in to comment.