Skip to content

Commit

Permalink
add matching logic for domain ingestion
Browse files Browse the repository at this point in the history
  • Loading branch information
eesanoble committed May 10, 2024
1 parent 35d879d commit 21b96f3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/kafka.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,10 @@ def _extract_record(
for tag_association in meta_tags_aspect.tags
]

meta_domain_aspect = meta_aspects.get(Constants.ADD_DOMAIN_OPERATION)
if meta_domain_aspect:
dataset_snapshot.aspects.append(meta_domain_aspect)

if all_tags:
dataset_snapshot.aspects.append(
mce_builder.make_global_tag_aspect_with_tag_list(all_tags)
Expand Down
4 changes: 3 additions & 1 deletion metadata-ingestion/src/datahub/utilities/mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,9 @@ def get_operation_value(
if term.strip()
]
elif operation_type == Constants.ADD_DOMAIN_OPERATION:
return mce_builder.make_domain_urn(operation_config[Constants.DOMAIN])
domain = operation_config[Constants.DOMAIN]
domain = _insert_match_value(domain, _get_best_match(match, "domain"))
return mce_builder.make_domain_urn(domain)
return None

def sanitize_owner_ids(self, owner_id: str) -> str:
Expand Down

0 comments on commit 21b96f3

Please sign in to comment.