Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math.sw primitive u256 missing trait implementations #5329

Closed
Braqzen opened this issue Dec 1, 2023 · 2 comments · Fixed by #5565
Closed

math.sw primitive u256 missing trait implementations #5329

Braqzen opened this issue Dec 1, 2023 · 2 comments · Fixed by #5565
Labels
enhancement New feature or request lib: std Standard library

Comments

@Braqzen
Copy link
Contributor

Braqzen commented Dec 1, 2023

No

  • sqrt
  • logarithm
  • binary logarithm
@Braqzen Braqzen added enhancement New feature or request lib: std Standard library labels Dec 1, 2023
@sudhackar
Copy link
Contributor

Is this prioritized already? I can pick this up.

@SwayStar123
Copy link
Member

@sudhackar Hi, feel free to make a PR to fix this issue, after you add the implementation and the tests you can request a review from me

This was referenced Feb 7, 2024
Closed
Merged
xunilrj pushed a commit that referenced this issue Feb 8, 2024
@sudhackar
u256: log, log2 and sqrt impl (#5329) (#5565)
046d292 
## Description
simple changes that uses newton's method for sqrt and decomposition to
`u64` for `log2` - `log` builds up on `log2` for `u256`

This should fix #5329

Ping @SwayStar123 
## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
sdankel pushed a commit that referenced this issue Feb 8, 2024
@sudhackar @sdankel
u256: log, log2 and sqrt impl (#5329) (#5565)
1a32c21 
## Description
simple changes that uses newton's method for sqrt and decomposition to
`u64` for `log2` - `log` builds up on `log2` for `u256`

This should fix #5329

Ping @SwayStar123 
## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

u256: log, log2 and sqrt impl (#5329)
u256: log, log2 and sqrt impl (#5329)
3 participants
@sudhackar @SwayStar123 @Braqzen