Skip to content

Commit

Permalink
u256: log, log2 and sqrt impl (#5329) (#5565)
Browse files Browse the repository at this point in the history
## Description
simple changes that uses newton's method for sqrt and decomposition to
`u64` for `log2` - `log` builds up on `log2` for `u256`

This should fix #5329

Ping @SwayStar123 
## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
  • Loading branch information
sudhackar authored Feb 8, 2024
1 parent 3406358 commit 046d292
Showing 1 changed file with 76 additions and 0 deletions.
76 changes: 76 additions & 0 deletions sway-lib-std/src/math.sw
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,24 @@ pub trait Root {
fn sqrt(self) -> Self;
}

impl Root for u256 {
// Integer square root using [Newton's Method](https://en.wikipedia.org/wiki/Integer_square_root#Algorithm_using_Newton's_method).
fn sqrt(self) -> Self {
let mut x0 = self >> 1;
if x0 == 0 {
return self;
}
let mut x1 = (x0 + self / x0) >> 1;

while x1 < x0 {
x0 = x1;
x1 = (x0 + self / x0) >> 1;
}

x0
}
}

impl Root for u64 {
fn sqrt(self) -> Self {
let index: u64 = 2;
Expand Down Expand Up @@ -193,15 +211,57 @@ impl BinaryLogarithm for u8 {
}
}

impl BinaryLogarithm for u256 {
fn log2(self) -> Self {
use ::assert::*;
assert(self != 0);
let (a, b, c, d) = asm(r1: self) {
r1: (u64, u64, u64, u64)
};
if a != 0 {
return a.log2().as_u256() + 0xc0u256;
} else if b != 0 {
return b.log2().as_u256() + 0x80u256;
} else if c != 0 {
return c.log2().as_u256() + 0x40u256;
} else if d != 0 {
return d.log2().as_u256();
}
self
}
}

impl Logarithm for u256 {
fn log(self, base: Self) -> Self {
let self_log2 = self.log2();
let base_log2 = base.log2();
self_log2 / base_log2
}
}

#[test]
fn square_root_test_math_sw() {
use ::assert::*;

let max_u256 = u256::max();
let max_u64 = u64::max();
let max_u32 = u32::max();
let max_u16 = u16::max();
let max_u8 = u8::max();

// u256
assert(0x1u256.sqrt() == 1);
assert(0x4u256.sqrt() == 2);
assert(0x9u256.sqrt() == 3);
assert(0x90u256.sqrt() == 12);
assert(0x400u256.sqrt() == 32);
assert(0x2386f26fc10000u256.sqrt() == 100000000);
assert(0x0u256.sqrt() == 0);
assert(0x2u256.sqrt() == 1);
assert(0x5u256.sqrt() == 2);
assert(0x3e8u256.sqrt() == 31);
assert(max_u256.sqrt() == 0xffffffffffffffffffffffffffffffffu256);

// u64
assert(1.sqrt() == 1);
assert(4.sqrt() == 2);
Expand Down Expand Up @@ -383,11 +443,27 @@ fn exponentiation_test_math_sw() {
fn logarithmic_test_math_sw() {
use ::assert::*;

let max_u256 = u256::max();
let max_u64 = u64::max();
let max_u32 = u32::max();
let max_u16 = u16::max();
let max_u8 = u8::max();

// u256
assert(0x2u256.log2() == 0x1u256);
assert(0x401u256.log2() == 0xau256);
assert(max_u256.log2() == 0xffu256);
assert(0x2u256.log(0x2u256) == 0x1u256);
assert(0x2u256.log2() == 0x1u256);
assert(0x1u256.log(0x3u256) == 0);
assert(0x8u256.log(0x2u256) == 0x3u256);
assert(0x8u256.log2() == 0x3u256);
assert(0x64u256.log(0xau256) == 0x2u256);
assert(0x64u256.log(0x2u256) == 0x6u256);
assert(0x64u256.log2() == 0x6u256);
assert(0x64u256.log(0x9u256) == 0x2u256);
assert(max_u256.log(0x2u256) == 0xffu256);

// u64
assert(2.log(2) == 1);
assert(2.log2() == 1);
Expand Down

0 comments on commit 046d292

Please sign in to comment.