grow_stack and empty $hp range write fixes #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
commented
Jul 4, 2024
| @@ -972,11 +977,10 @@ impl OwnershipRegisters { | |||
|
|
|||
| /// Empty range is owned iff the range.start is owned | |||
| pub(crate) fn has_ownership_heap(&self, range: &Range<Word>) -> bool { | |||
| // TODO implement fp->hp and (addr, size) validations | |||
There was a problem hiding this comment.
These were already implemented, so this comment was obsolete.
Voxelot
approved these changes
Jul 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two minor bugs in the memory implementation:
grow_stackwas silently truncating thesptoMEM_SIZEeven if it was above that$hpwould fail ownership check, even if they really should passChecklist
grow_stackcase is not tested, as it's not really reachable externally.Before requesting review