Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ContractCreated output in the Create transaction #785

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Require ContractCreated output in the Create transaction #785

merged 2 commits into from
Jul 1, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jul 1, 2024

Specification requires to have one and only one ContractCreated=) We forgot to check that we have at least one=D

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested a review from a team July 1, 2024 11:19
@xgreenx xgreenx self-assigned this Jul 1, 2024
@xgreenx xgreenx added this pull request to the merge queue Jul 1, 2024
Merged via the queue into master with commit 045772f Jul 1, 2024
39 checks passed
@xgreenx xgreenx deleted the bugfix/create-transaciton-doesnt-require-contract-created branch July 1, 2024 12:59
@xgreenx xgreenx mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentosal Dentosal Dentosal approved these changes

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgreenx @Dentosal