test: BMT proof verify tests and additional verify logic #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvrooman
changed the title
xgreenx
reviewed
Apr 12, 2024
| let (root, proof_set) = tree.prove(index as u64).expect("Unable to generate proof"); | ||
|
|
||
| // When | ||
| let verification = verify(&root, &data, &proof_set, index as u64, num_leaves as u64 + 1); |
There was a problem hiding this comment.
It would be nice to have random num_leaves here as well
There was a problem hiding this comment.
Hmm, I made this change locally but proptest is reporting failures. I will need to dig into this.
There was a problem hiding this comment.
What failures do you have? Is that in cases when num_leaves is more than the real number of leaves?
|
The change looks good=) Waiting for the updated test and I'm ready to approve |
xgreenx
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #716
This PR:
binary::verifyfunction to check the proof index against the length of the proof set. The proof index tells us the minimum size of the tree's leaf set. The provided proof set along the leaf-root path must be compatible with the calculated path length.binary::verifyto ensure correctness of algorithmChecklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]