Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access to {asset_id,to,amount} fields for Variable and Change outputs #675

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add access to {asset_id,to,amount} fields for Variable and Change outputs #675

merged 3 commits into from
Feb 28, 2024
+25 −3

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Feb 12, 2024 •
edited
Loading

Closes #650

@Dentosal
Copy link
Member Author

After #678 accessing fields of Output::Variable no longer make sense. Also, as Voxelot pointed out above, Output::Change amount is always zero, so better leave that one out as well.

@Dentosal Dentosal marked this pull request as ready for review February 28, 2024 16:36
@Dentosal Dentosal requested a review from a team February 28, 2024 16:37
@Dentosal Dentosal added breaking A breaking api change fuel-vm Related to the `fuel-vm` crate. labels Feb 28, 2024
@xgreenx xgreenx added this pull request to the merge queue Feb 28, 2024
Merged via the queue into master with commit 3ff9965 Feb 28, 2024
72 of 81 checks passed
@xgreenx xgreenx deleted the dento/gtf-change-fields branch February 28, 2024 16:52
@xgreenx xgreenx mentioned this pull request Feb 29, 2024
Merged
@bitzoic bitzoic mentioned this pull request Sep 18, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot left review comments

@xgreenx xgreenx xgreenx approved these changes

Assignees

@Dentosal Dentosal

Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be able to get the AssetId & To for a Change output
3 participants
@Dentosal @Voxelot @xgreenx