Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ReceiptsCtx to u16::MAX receipts #633

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Nov 9, 2023

Closes #620
Spec PR: FuelLabs/fuel-specs#535

@Dentosal Dentosal added breaking A breaking api change fuel-vm Related to the `fuel-vm` crate. labels Nov 9, 2023
@Dentosal Dentosal self-assigned this Nov 9, 2023
@Dentosal Dentosal marked this pull request as ready for review November 9, 2023 10:33
@Dentosal Dentosal requested a review from a team November 9, 2023 10:49
@xgreenx xgreenx added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit fcf6a2a Nov 9, 2023
37 checks passed
@xgreenx xgreenx deleted the dento/receipt-limit branch November 9, 2023 13:42
Dentosal added a commit to FuelLabs/fuel-specs that referenced this pull request Nov 10, 2023
Increases the receipt limit from `u8::MAX` to `u16::MAX`, leaving space
for panic and script result. The old limit was not enforced, but
FuelLabs/fuel-vm#633 is going to enforce the new
rules defined here.

The number of receipts is limited separtely from gas, since adding more
receipts slows down all instructions that operate on them. Moreover,
this change makes the upper bound for memory use clear.
@xgreenx xgreenx mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AppendReceipt to limit the total number of possible receipts to u16::MAX
3 participants