feat: Charge for Create metadata
#618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/FuelLabs/fuel-vm into bvrooman/feat/charge-for-input-signature-recovery
…ttps://github.com/FuelLabs/fuel-vm into bvrooman/feat/charge-for-input-signature-recovery
Update contract is_empty
bvrooman
force-pushed
the
bvrooman/feat/charge-for-create-metadata
branch
from
1780190
to
8c1ab35
Compare
Base automatically changed from
bvrooman/feat/charge-for-input-signature-recovery
to
master
October 30, 2023 18:32
bvrooman
changed the title
Create metadata
xgreenx
reviewed
Oct 31, 2023
| let state_root_length = storage_slots.len() as Word; | ||
| let state_root_gas = gas_costs.state_root.resolve(state_root_length); | ||
|
|
||
| let contract_id_gas = gas_costs.contract_id; |
There was a problem hiding this comment.
contract_id calculation is simply the calling of the hash functions. You can use dependent cost for hash function instead
xgreenx
approved these changes
Oct 31, 2023
Merged
This was referenced Nov 1, 2023
Voxelot
reviewed
Nov 1, 2023
|
|
||
| let contract: Option<Contract> = witnesses | ||
| .get(*bytecode_witness_index as usize) | ||
| .map(|c| c.as_ref().into()); |
There was a problem hiding this comment.
Should we just get the len here? Based on the type annotation above is seems like we're creating an owned copy of the contract which is going to add a lot more overhead to the gas calculation.
There was a problem hiding this comment.
Yep, I can update that in follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
Createtransaction forContractIdcalculate and validation #600This PR extends the gas costs to include costs for contract state root and contract id.
The gas costs are not final and will need to be calculated by running benchmarks on a dedicated instance.