Remove BlockHeight arithmetic #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
force-pushed
the
dento/remove-block-height-arithmetic
branch
from
c9aff5a
to
e6b5be5
Compare
xgreenx
approved these changes
Oct 2, 2023
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Oct 3, 2023
…#1392) Fixes #1334 See FuelLabs/fuel-vm#596 for follow-up work. --------- Co-authored-by: Green Baneling <XgreenX9999@gmail.com> Co-authored-by: Brandon Vrooman <brandon.vrooman@fuel.sh>
Merged
GoldenPath1109
added a commit
to GoldenPath1109/fuel-core
that referenced
this pull request
Sep 7, 2024
… (#1392) Fixes FuelLabs/fuel-core#1334 See FuelLabs/fuel-vm#596 for follow-up work. --------- Co-authored-by: Green Baneling <XgreenX9999@gmail.com> Co-authored-by: Brandon Vrooman <brandon.vrooman@fuel.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in FuelLabs/fuel-core#1334, the
BlockHeighttype should have error-prone arithmetic implementations. In this case it was possible to silently wrap the result, which is even worse.