Minor readibility improvements #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
previously approved these changes
Jun 8, 2023
| ) | ||
| .checked_add(length as Word) | ||
| .ok_or(PanicReason::MemoryOverflow)?; | ||
| let length = Word::from_be_bytes(self.memory[fp_code_size..fp_code_size_end].try_into().unwrap()) |
There was a problem hiding this comment.
[nit] It it better to use expect even if we checked it above=)
| .and_then(|data| try_mem_write(a as usize, data.as_ref(), owner, memory))?; | ||
|
|
||
| let coinbase = storage.coinbase().map_err(RuntimeError::from_io)?; | ||
| try_mem_write(a as usize, coinbase.as_ref(), owner, memory)?; |
There was a problem hiding this comment.
Hmm, do we still need a as usize here?
| @@ -305,48 +312,17 @@ where | |||
| } | |||
| .prepare_call() | |||
| } | |||
|
|
|||
| /// Prepare a call instruction for execution | |||
| pub fn prepare_call(&mut self, ra: RegId, rb: RegId, rc: RegId, rd: RegId) -> Result<(), RuntimeError> { | |||
There was a problem hiding this comment.
FInally, someone did that=D Thank you <3
bvrooman
previously approved these changes
Jun 9, 2023
xgreenx
approved these changes
Jun 9, 2023
xgreenx
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from #461 but extracted here for a separate review.
No externally visible changes, only internal readibility improvements.