Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add end_block field in manifest #824

Merged
merged 8 commits into from
May 5, 2023
Merged

enhancement: add end_block field in manifest #824

merged 8 commits into from
May 5, 2023

Conversation

0xmovses
Copy link
Contributor

@0xmovses 0xmovses commented Apr 27, 2023 •
edited
Loading

Closes #796

Changes

• Updates executor.rs with logic needed for end_block
• Updates Manifest
• Adds new tests.
• Updates docs and example manifest files.

CI with new test cases added should all pass.

@0xmovses 0xmovses added documentation Improvements or additions to documentation enhancement labels Apr 27, 2023
@0xmovses 0xmovses self-assigned this Apr 27, 2023
@0xmovses 0xmovses marked this pull request as draft April 27, 2023 12:35
ra0x3

This comment was marked as spam.

Sign in to view

@0xmovses 0xmovses marked this pull request as ready for review May 3, 2023 18:50
@0xmovses 0xmovses requested review from deekerno and ra0x3 May 4, 2023 14:26
deekerno
deekerno suggested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@deekerno deekerno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for the most part. Left feedback about the added warn! statement.

packages/fuel-indexer/src/executor.rs Outdated Show resolved Hide resolved
packages/fuel-indexer/src/executor.rs Outdated Show resolved Hide resolved
@0xmovses 0xmovses requested a review from deekerno May 4, 2023 15:49
@0xmovses 0xmovses merged commit 6e63015 into master May 5, 2023
@0xmovses 0xmovses deleted the rich/796-end-block branch May 5, 2023 09:50
@ra0x3
Copy link
Contributor

ra0x3 commented May 6, 2023

@deekerno @rvmelkonian Just FYI this PR forgot to add the end_block to the default forc index manifest. Let's fix that in a quick little follow up 🙏🏽

@0xmovses
Copy link
Contributor Author

0xmovses commented May 6, 2023

@ra0x3 Noted thanks for the reminder, will put that up in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deekerno deekerno deekerno approved these changes

@ra0x3 ra0x3 Awaiting requested review from ra0x3

Assignees

@0xmovses 0xmovses

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an end_block field in manifest
3 participants
@0xmovses @ra0x3 @deekerno