Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an end_block field in manifest #796

Closed
0xmovses opened this issue Apr 24, 2023 · 0 comments · Fixed by #824
Closed

Add an end_block field in manifest #796

0xmovses opened this issue Apr 24, 2023 · 0 comments · Fixed by #824
Assignees

Comments

@0xmovses
Copy link
Contributor

0xmovses commented Apr 24, 2023

Brought up by @ra0x3 in team sync today, users should be able to add an end_block field, to determine when an indexer should stop indexing. Without this, all indexers by default will run and listen for events on new blocks indefinitely.

• Add a new field in the manifest file, update Manifest struct and add the logic necessary to achieve this functionality.

• Additionally, if no end_block is set, we should display a very clear warning message when the indexer starts, notifying users that this index will run until explicitly stopped.

• In the PR an e2e test and documentation should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant