-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: stop-previous
flag to remove wasm binary by index_id
#808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmovses
changed the title
bugfic: stop-previous to remove by wasm binary version id
bugfic: stop-previous to remove wasm binary by version id
Apr 26, 2023
0xmovses
changed the title
bugfic: stop-previous to remove wasm binary by version id
bugfic: Apr 26, 2023
stop-previous
flag to remove wasm binary by version id
0xmovses
changed the title
bugfic:
bugfix: Apr 26, 2023
stop-previous
flag to remove wasm binary by version idstop-previous
flag to remove wasm binary by version id
0xmovses
changed the title
bugfix:
enhancement: Apr 26, 2023
stop-previous
flag to remove wasm binary by version idstop-previous
flag to remove wasm binary by index_id
0xmovses
changed the title
enhancement:
bugfix: Apr 26, 2023
stop-previous
flag to remove wasm binary by index_id
stop-previous
flag to remove wasm binary by index_id
ra0x3
suggested changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. Did not test. Will try that next time.
@rvmelkonian In the mean time, can we update the PR with manual testing steps for when its ready to be tested?
examples/block-explorer/explorer-indexer/explorer_indexer.manifest.yaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786
Note that the changes to the plugin side were already merged to master, and then reverted. The changes to the plugin are on this branch, but the diff doesn't show because of the previous merge.
Changelog
• Adds conditional logic based on query param to
remove_indexer
.• Adds
remove_previous_indexer
queries function.• Adds metrics for new query function.
Testing
cargo build -p forc-index -p fuel-indexer --release --features fuel-core-lib
../target/release/forc-index deploy --path examples/block-explorer/explorer-indexer
select * from index_asset_registry_manifest;
lib.rs
of the block explorer../target/release/forc-index deploy --stop-previous --path examples/block-explorer/explorer-indexer
select * from index_asset_registry_manifest;
You should see that there is still only one wasm binary with the same index_id of 1. The old one was removed.