Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forc index deploy to automagically stop the current version of the indexer #786

Closed
ra0x3 opened this issue Apr 21, 2023 · 1 comment · Fixed by #788
Closed

Allow forc index deploy to automagically stop the current version of the indexer #786

ra0x3 opened this issue Apr 21, 2023 · 1 comment · Fixed by #788
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Apr 21, 2023

  • We have the ability to deploy new indexers to an indexer service via forc index deploy
  • When this new indexer is deployed, it starts to index data immediately
  • However, any previous version of the indexer that has not been explicitly stopped, will continue to run
  • Given that indexer migrations feature: index migrations #382 don't really make the most sense given our setup, the main way to "migrate data" is to update your schema, rebuild your indexer, then redeploy
  • This is simpler than it seems: you just edit your schema file then do another forc index deploy
  • However, in order to ensure that users can deploy this new indexer without having to go back and manually stop an older version, we should add some flag to forc index deploy that will automagically stop any indexer running under that namespace/identifier combination
  • Something like forc index deploy --stop-previous would upload the new indexer and stop any previous version
    • Call the flag whatever you want that makes sense
@ra0x3
Copy link
Contributor Author

ra0x3 commented May 11, 2023

@rvmelkonian Looks like @deekerno has already done this #640. I think this might be good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants