Disable SMT for ContractsAssets and ContractsState
#2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Jul 24, 2024
MitchTurner
reviewed
Jul 25, 2024
| &self, | ||
| ) -> Result<Bytes32, <Database as StorageInspect<ContractsState>>::Error> { | ||
| self.database.root(&self.contract_id).map(Into::into) | ||
| impl<Database> ContractRef<Database> |
There was a problem hiding this comment.
Not sure why this is a separate impl block still. The signatures look the same now and were different before. Might be missing something with my visual diff though :)
| + MerkleRootStorage<ContractId, ContractsState, Error = StorageError> | ||
| + MerkleRootStorage<ContractId, ContractsAssets, Error = StorageError>, | ||
| { | ||
| type InnerError = StorageError; |
There was a problem hiding this comment.
StorageError seems arbitrary here. Can we just say that it's the same E as the other assoc Errors?
| where | ||
| D: StorageInspect<ContractsLatestUtxo, Error = StorageError>, | ||
| { | ||
| type InnerError = StorageError; |
| } | ||
|
|
||
| impl<'a, Database> ContractRef<&'a Database> | ||
| where | ||
| Database: ContractStorageTrait, | ||
| anyhow::Error: From<Database::InnerError>, | ||
| &'a Database: ContractStorageTrait<InnerError = StorageError>, |
There was a problem hiding this comment.
StorageError seems like an implicit way of getting the right value based on the impls we have above.
E: Into<StorageError>,
&'a Database: ContractStorageTrait<InnerError = E>,
might be more accurate, right?
There was a problem hiding this comment.
I think this one is fine. In reality, it looks like we're just using the ContractStorageTrait as a sort of alias for all the other traits. I don't think we're using it anywhere else. But I'm not going to nitpick too much. I guess I'm just not a huge fan of the sort of inheritance-ness going on here.
MitchTurner
reviewed
Jul 26, 2024
# Conflicts: # CHANGELOG.md # Cargo.lock # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm
MitchTurner
approved these changes
Aug 2, 2024
Merged
MitchTurner
added a commit
that referenced
this pull request
Aug 6, 2024
## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in #1983 * Weekly `cargo update` by @github-actions in #2029 * Add V0 algorithm to actual services by @MitchTurner in #2025 * Weekly `cargo update` by @github-actions in #2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in #2041 * Ignore the message receipt if transaction is reverted by @xgreenx in #2045 * feat: add chain config to Docker images by @mchristopher in #2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in #1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in #2048 ## New Contributors * @mchristopher made their first contribution in #2052 **Full Changelog**: v0.31.0...v0.32.0
GoldenPath1109
added a commit
to GoldenPath1109/fuel-core
that referenced
this pull request
Sep 7, 2024
## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in FuelLabs/fuel-core#1983 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2029 * Add V0 algorithm to actual services by @MitchTurner in FuelLabs/fuel-core#2025 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in FuelLabs/fuel-core#2041 * Ignore the message receipt if transaction is reverted by @xgreenx in FuelLabs/fuel-core#2045 * feat: add chain config to Docker images by @mchristopher in FuelLabs/fuel-core#2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in FuelLabs/fuel-core#1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in FuelLabs/fuel-core#2048 ## New Contributors * @mchristopher made their first contribution in FuelLabs/fuel-core#2052 **Full Changelog**: FuelLabs/fuel-core@v0.31.0...v0.32.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2042
Added "smt" feature to the
fuel-core-storageto enable old behavior. The SMT still is used in the tests and in benchmarks but disabled for the "production" mode.Checklist
Before requesting review