This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
BREAKING CHANGE: show notification message #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GusBaamonde
commented
Apr 26, 2019
GusBaamonde
commented
- Adapt the user-menu container to be able to show it by class and not by ID, reusing the style of the container
| @@ -11,8 +11,8 @@ $("body").on({ | |||
| } | |||
| }, ".menu-main .submenu-item"); | |||
|
|
|||
| $("body").on('click', '#user-menu--open', function() { | |||
| $('.user-menu').toggleClass('open'); | |||
| $("body").on('click', '.user-menu--open', function() { | |||
There was a problem hiding this comment.
It is not a breaking change?
GusBaamonde
changed the title
|
Relacionado con: FromDoppler/doppler-webapp#148 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.