Fix missing / non-array user.ranks() issue on v17development/flarum-support #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to v17development/flarum-support-feedback#14 which causes support page to break.
Changes proposed in this pull request:
This change adds a conditional check to make sure the
user.ranks()
is actually loaded. If the rank is falsey, it does not try to add user rank to the PostUser view.Reviewers should focus on:
Screenshot
![image](https://private-user-images.githubusercontent.com/16628119/288167070-d27bc967-2ac0-4592-a9e4-e1e13f7b26cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ4NjM3OTYsIm5iZiI6MTcyNDg2MzQ5NiwicGF0aCI6Ii8xNjYyODExOS8yODgxNjcwNzAtZDI3YmM5NjctMmFjMC00NTkyLWE5ZTQtZTFlMTNmN2IyNmNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI4VDE2NDQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjOGIzM2VkMjQ1MTcwNGQ3Mjg5NjMxNDBmZTQ4NGJiY2I2NmFlMDRhYjE3MTEzOWVjY2MzNWNiODM5MDdlZmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SYrpXbUdtEBbRMhJkG9fB5306O5UuCLYKvBdlsnuPvw)
This is how the support tickets page was breaking:
And here's the console log showing the
![image](https://private-user-images.githubusercontent.com/16628119/288167127-a65aa03b-f6e3-400e-a18b-feabbef39ef1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ4NjM3OTYsIm5iZiI6MTcyNDg2MzQ5NiwicGF0aCI6Ii8xNjYyODExOS8yODgxNjcxMjctYTY1YWEwM2ItZjZlMy00MDBlLWExOGItZmVhYmJlZjM5ZWYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI4VDE2NDQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2NzRiMmVmOTQ2YWM3MGEwYzk2N2M3OWNhMjkyOWI5ZGUwZjc5ZjY3MjlmNmYxYTE0N2FlYTVlZmIxODE4MTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GyKPoB-9jCrSh4-q2QiM05WJct0lLFFm7fWLJiXHTgA)
ranks()
trying toreverse()
which is not available since it's not an array:Confirmed
composer test
).Required changes:
N/A