New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use h3 tag for PostUser name #104

Open

rob006 wants to merge 1 commit into FriendsOfFlarum:master from rob006:post-user-name-tag

Contributor

rob006 commented Mar 12, 2023

Adjustments for flarum/framework#3732

It uses class name instead of targeting h3 tag in find() call, so code should work after planned changes in Flarum 2.0.
I switched used tag from h3 to div - this was originally planed in core, but was postponed to 2.0 because of BC break. In case of this extension BC break should have much less impact than in core, so it may be OK to switch early to markup planned for Flarum 2.0.

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).


          Do not use h3 tag for PostUser name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment