Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings for notifications about downvote/upvote are visible even if user does not have permissions to get such notifications #90

Closed
rob006 opened this issue Aug 19, 2022 · 0 comments · Fixed by #96
Closed

Settings for notifications about downvote/upvote are visible even if user does not have permissions to get such notifications #90

rob006 opened this issue Aug 19, 2022 · 0 comments · Fixed by #96
Assignees
@imorland
Labels
bug Something isn't working

Comments

@rob006
Copy link
Contributor

rob006 commented Aug 19, 2022

In admin panel I disallowed regular users to get notifications about upvotes/downvotes and it seems to be working. But user still has related notifications settings in https://forum.example.com/settings

7e59cb64
@rob006 rob006 added the bug Something isn't working label Aug 19, 2022
@imorland imorland self-assigned this Oct 25, 2022
imorland added a commit that referenced this issue Oct 25, 2022
@imorland
fix: Only display vote notification settings when a user can actually…
8f6f0c2 
… recieve them, based on admin settings #90
@imorland imorland mentioned this issue Oct 25, 2022
Merged
@imorland imorland linked a pull request Oct 25, 2022 that will close this issue
Various fixes #96
Merged
imorland added a commit that referenced this issue Oct 25, 2022
@imorland @StyleCIBot
Various fixes (#96)
4fbd0c1 
* fix: Only display vote notification settings when a user can actually recieve them, based on admin settings #90

* Apply fixes from StyleCI

* fix: php8.1 error when settings key is null

* fix: error when rank badges preference is not zero #29

* feat: option to prevent users voting for themselves #28

* Apply fixes from StyleCI

Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imorland imorland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes FriendsOfFlarum/gamification
2 participants
@rob006 @imorland