-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on npm #1269
Remove dependency on npm #1269
Conversation
Quick review:
Will look into it more during the weekend. |
Fixed both of those. |
The build is currently failing because We currently have a lot of Lines 699 to 720 in 621a04f
We could also change them to use their *Async versions instead because we promisify fs hereungit/source/utils/fs-async.js Line 4 in 621a04f
|
This will also reduce the electron package size by a few MB. (ungit-linux-x64.zip 98.9MB → 91.6MB in my environment.) |
type: 'text', | ||
additions: '3', | ||
deletions: '0' | ||
return common.get(req, '/status', { path: testDirMain }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Currently, ungit has a dependency on the whole
npm
package, which is only used to check latest versions on the npm registry.This change replaces
npm
with more light-weight solutions to provide the same functionality.