Update support matrix

[NullVoxPopuli]

No description provided.

[jrjohnson]

My only objection is depending on the unstable getGlobalConfig from @embroider/macros without any guarantees around this API or its compatibility with older builds. It's super difficult to actually test application configuration in the dummy app, so we'll need to validate this change continuously with any version bump of embroider. I'm hesitant to take on that maintenance burden and I'm wondering if embroider-build/embroider#770 means we can keep our existing usage of ember-get-config?

[NullVoxPopuli]

Unless embroider-build/embroider#770 isn't released, that PR wasn't enough to not need the changes in this PR (#174): NullVoxPopuli/limber#114

without any guarantees around this API or its compatibility with older build

is ember-try not sufficient? 🤔

[jrjohnson]

is ember-try not sufficient

I wish! But testing an add-on against multiple different application configurations isn't doable without jumping through hoops.

I believe the compatibility fixes are in 0.41.0 so it is released, sad it isn't working. I'll find some time to poke around in getGlobalConfig and see how complicated it is (and how likely it is to be a problem for us down the road).

[NullVoxPopuli]

anything keeping this from being merged? what are remaining tasks?
I've been happily pointing at this fork since I put up the PR :D

[jrjohnson]

It's on my list for today. Wanna rebase it?

[jrjohnson]

Most of the changes are now done in other work, so it should just be adding the config macro and activating the tests in GitHub workflows. I'll take care of it if you'd like. Thanks for the work and the help figuring out how this fits together.

[jrjohnson]

Actually looking at discord chat @NullVoxPopuli I think I'd like to hold off to see if ember-get-config can get working with embroider. That would be my idea upgrade path because it seems less risky.

[NullVoxPopuli]

what's the verdict?

[jrjohnson]

Waiting on mansona/ember-get-config#29 As far as I can tell something needs to be fixed in embroiderer.

[davideferre]

Waiting on mansona/ember-get-config#29 As far as I can tell something needs to be fixed in embroiderer.

@jrjohnson ember-get-config is been updated to 1.0.0 version with Embroider support!

[jrjohnson]

Thanks @davideferre, if you feel like opening a PR with that update I'd be happy to merge it.

[davideferre]

Thanks @davideferre, if you feel like opening a PR with that update I'd be happy to merge it.

Thanks @jrjohnson I've created PR #192

[jrjohnson]

Thanks for getting this so far @NullVoxPopuli and for the advocacy upstream to get everything in shape. Closing in favor of #192